Connecting to database verbose output occurs twice.

ChestShop-authors / ChestShopNotifier

Bukkit plugin that allows your players to see who bought or sold what while they were offline.

https://www.spigotmc.org/resources/chestshopnotifier.30313/

10 stars 8 forks source link

Connecting to database verbose output occurs twice. #5

Closed mibby closed 7 years ago

mibby commented 8 years ago

From console / logs, connecting to database outputs twice. Not sure if intended or it spams connections until it connects?

[04:01:36] [Server thread/INFO]: [ChestShopNotifier] Enabling ChestShopNotifier v1.1.5
[04:01:36] [Server thread/INFO]: [ChestShopNotifier] Connecting to the database...
[04:01:36] [Server thread/INFO]: [ChestShopNotifier] Connecting to the database...
[04:01:36] [Server thread/INFO]: [ChestShopNotifier] Connected!

Phoenix616 commented 8 years ago

Yeah, looks like it opens a connection twice, once in the updateConfiguration call here and once 4 lines below again.

The whole database connection handling in general looks kinda wonky to me...

mibby commented 8 years ago

Any plans on rewriting it anytime soon?

mibby commented 8 years ago

@Phoenix616 Any update to all the SQL errors? :/

Phoenix616 commented 8 years ago

Sorry, I currently don't have any time to properly maintain this plugin further than to just keep it working. I'm open for PR's addressing this problem or the whole database situation 'though.

mibby commented 8 years ago

:( Well if you ever do find the time, I'll be here to help test all the SQL exceptions.

Phoenix616 commented 7 years ago

Fixed with 93b9c2ba