Chevrotain / chevrotain

Parser Building Toolkit for JavaScript
https://chevrotain.io
Apache License 2.0
2.48k stars 204 forks source link

Broken Links in the docs #1751

Closed kevinkhill closed 2 years ago

kevinkhill commented 2 years ago

Hello. I hope I reach you all as a fellow in hopes of helping, not nit picking 😃 With my intentions set, I ran your docs through a random link-checker site I found and 😮

image

kevinkhill commented 2 years ago

I'm happy to continue and open pull requests as I find them unless your team would rather just do it all as one thorough update

bd82 commented 2 years ago

I wonder if we can automate the dead links checks as part of the CI process. The problem is that at some points in the life-cycle links may be temporarily invalid.

Perhaps a script to check links would be useful, but only run it manually once in a while or maybe an automated daily build...

kevinkhill commented 2 years ago

I was thinking about this on my way to work this morning about some little script that could ping the links once deployed for 404s and then maybe collect them as a little report

On Wed, Jan 26, 2022, 3:56 PM Shahar Soel @.***> wrote:

I wonder if we can automate the dead links checks as part of the CI process. The problem is that at some points in the life-cycle links may be temporarily invalid.

  • e.g: until next version is actually deployed

Perhaps a script to check links would be useful, but only run it manually once in a while or maybe an automated daily build...

— Reply to this email directly, view it on GitHub https://github.com/Chevrotain/chevrotain/issues/1751#issuecomment-1022711922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACA6XCELC2MIZPE6ROCOJDUYCC37ANCNFSM5MYFUQQQ . You are receiving this because you authored the thread.Message ID: @.***>

bd82 commented 2 years ago

There is a slight problem mapping the links back to the markdown But it should not be too hard, particularly once the situation is resolved and there would only be a few dead links once in a while...

I wonder if there is some npm package with a crawler that does it. I should be able to figure out how to do a daily execution of the script on Github Actions.

bd82 commented 2 years ago

This looks like a possible good option for the tool to be used

kevinkhill commented 2 years ago

Skimming the README, it does sound very promising!

bd82 commented 2 years ago

Unfortunately it seems linkinator does not work well with a Single Page Application such as the vuepress generated documentation.

bd82 commented 2 years ago

This looks like a good website for checking dead links

bd82 commented 2 years ago

Bad links found: