search

ChewKeanHo / AutomataCI

An open-source, redistributable, template-guided, and semi-autonomous CI infrastructure readily available your next project.
Apache License 2.0
18 stars 1 forks source link

Refactor MSI Packager To a More Maintainable Way #342

Open hollowaykeanho opened 1 week ago

hollowaykeanho commented 1 week ago

Description

This includes:

  1. Closing this issue: https://github.com/wixtoolset/issues/issues/7896
  2. detect both binary and library built artifact instead of relying on placeholder files.
  3. Ensures the new enhancement are applied.

Expected Behavior

MSI packager works as usual, the github issue is closed so that the upstream folks can have peace in mind and move on.

Current Behavior

MSI packager is wey too complicated and the upstream github issue is holding things up. Upstream team is annoyed with the slow timeline already.

Associated Data Files

No response

hollowaykeanho commented 1 week ago

Begin upgrades.

hollowaykeanho commented 1 week ago

Issue has already been updated with the LCID findings and -culture argument test results. Once the CI is passing from the hestiaERROR project, upstream to this repository is then possible.

hollowaykeanho commented 1 week ago

Will not be backward compatible since the refactoring efforts are way cleaner and disruptive + using a single install pack per language rather than assembling things manually.

corygalyna commented 1 week ago

I would suggest you drop the upstream tracking as a criteria. The 2 issues are isolated now and you can close this issue upon upstream.

hollowaykeanho commented 1 week ago

noted.

hollowaykeanho commented 1 week ago

implemented in ef00944278bdbe9d3a502104844c9151da161215