fix: Fixed labels and device name

ChewbaccaCookie / voicemeeter-connector

A Connector to use the Voicemeeter API

https://chewbaccacookie.github.io/voicemeeter-connector/

MIT License

28 stars 8 forks source link

fix: Fixed labels and device name #26

Closed edo2313 closed 3 years ago

edo2313 commented 3 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug Fix
What is the current behavior? (You can also link to an open issue here) Getting label returns 0
What is the new behavior (if this is a feature change)? Getting label returns the correct value
Other information: Thanks to @terenc3 for pointing out the issue and suggesting a fix

terenc3 commented 3 years ago

Works fine for me (Label / device.name)

grafik

The truncated text at the third entry also appears in voicemeeters dropdowns when using MME (in and out). I guess it is a problem there

ChewbaccaCookie commented 3 years ago

Hi, thank you @edo2313 and @terenc3. Your changes have been merged in PR #28.

edo2313 commented 3 years ago

Works fine for me (Label / device.name)

The truncated text at the third entry also appears in voicemeeters dropdowns when using MME (in and out). I guess it is a problem there

will check later, I only tested with the active one and not all devices so I coud have missed something in MME, but it should be the same as the others... Also @ChewbaccaCookie remember to change the version number in package.json

terenc3 commented 3 years ago

Nothing to check here. According to https://en.wikipedia.org/wiki/Windows_legacy_audio_components

Device name length in MME is restricted to 31 characters so long device names may appear only partially.

grafik