feat: Add a way to set options for voicemeeter

ChewbaccaCookie / voicemeeter-connector

A Connector to use the Voicemeeter API

https://chewbaccacookie.github.io/voicemeeter-connector/

MIT License

28 stars 8 forks source link

feat: Add a way to set options for voicemeeter #31

Closed jasperdevries closed 2 years ago

jasperdevries commented 2 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Being able to set options within voicemeter through this package, not just bus or strip values but everything.
What is the current behavior? (You can also link to an open issue here) Currently this is not possible, i saw someone else also made a request for it here
What is the new behavior (if this is a feature change)? You can now set any command in voicemeter
Other information:

Ellarddekoeijer commented 2 years ago

@ChewbaccaCookie Any chance that this can be merged? I need this exact functionality

ChewbaccaCookie commented 2 years ago

Hi @Ellarddekoeijer and @jasperdevries, sry I got no notification for this. Thank you for your work. The PR looks good. Could you please increase the package.json version by a minor release from v1.0.3 to v1.1.0? Then I would merge your changes.

ChewbaccaCookie commented 2 years ago

It seems that building is broken again. I'll have a look at this later on this day.

jasperdevries commented 2 years ago

Hello @ChewbaccaCookie , Thanks for looking at this. I updated the version in the package.json.

ChewbaccaCookie commented 2 years ago

Hi @jasperdevries, the building Issues has been fixed in #32. Either merge main manually or merge the following PR: https://github.com/jasperdevries/voicemeeter-connector/pull/1

jasperdevries commented 2 years ago

@ChewbaccaCookie thanks for fixing these issues. I've manually merged the changes.

ChewbaccaCookie commented 2 years ago

Thank you @jasperdevries for your contribution 🎉. The changes has been published and are available in Release 1.1.0