Closed RagingLink closed 6 months ago
Hi @RagingLink, thank you for your contribution. The feature looks fine for me. Could you please increase the minor version to 1.3.0? After this, we can merge your changes and release a new version. Merry Christmas 🎄
Done. Thank you so much for the quick response :) Happy holidays 🎆
This feature is now released in v1.3.0 🚀
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Adds a
getOption
method that gets other parameters available in the remote api, feel like it should be a thing with.setOption
existing :)What is the current behavior? (You can also link to an open issue here)
Not available
What is the new behavior (if this is a feature change)?
You can now get all parameters from voicemeeter
Other information: I don't personally agree with the naming of the method
setOption
, I feel like it should just besetParameter
as that's what voicemeeter also uses (VoicemeeterRemoteAPI.pdf), but I've decided to just stick to the name 'option' established by https://github.com/ChewbaccaCookie/voicemeeter-connector/pull/31.This would also resolve https://github.com/ChewbaccaCookie/voicemeeter-connector/issues/34