ChewyChair / pe

0 stars 0 forks source link

Missing return arrow in Section 3.1 Sequence Diagram #14

Open ChewyChair opened 2 years ago

ChewyChair commented 2 years ago

Highlighted in red is the missing return arrow. I understand that the return arrow may be omitted if it does not return anything, however highlighted in green are return arrows that return nothing. Perhaps a return arrow could be added here to maintain consistency.

image.png

nus-se-bot commented 2 years ago

Team's Response

Return arrow is not a requirement as part of UML specification.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is not, however in the sequence diagram there is an inconsistency regarding the use of return arrows for methods with no return values. It would perhaps be better if all methods with no return values followed the same convention (either an unlabelled return arrow or no return arrow at all for ALL such methods) to avoid confusion. The user could be left wondering if there is any difference between no return arrow, and an unlabelled return arrow, since both are present in this diagram.