search

ChewyChair / pe

0 stars 0 forks source link

Able to add duplicate lessons #8

Open ChewyChair opened 2 years ago

ChewyChair commented 2 years ago

As per title. Perhaps it would be better if the app was able to block this and print an error message.

image.png

nus-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate items

image.png

As can be seen from the screenshot above, it seems like I am able to add duplicate items. I am unsure if this is a bug or not but it does not seem to make sense to be able to add duplicate items.

[original: nus-cs2113-AY2122S1/pe-interim#1219] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The philosophy behind our design is that, the user is free to do anything that does not interfere with the secure and normal operation of the program, i.e. we should facilitate the user with their intention as far as possible, not hinder them based on our presumed non-essential problems. It is not different from the Unix philosophy, which has long allowed rm -rf / to be executed. Whether the operation makes sense or not is up to the user. It might be useful to add a friendly message for this (similar to the --no-preserve-root thing or the messages by git for unset default branch names/merge policy), but it is outside of our current function scope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue covers the duplication of lessons, not tasks. While I agree that users may choose to duplicate tasks for whatever reason, there is no good reason for a user to be able to duplicate lessons. If they mistakenly add duplicate lessons, there is no error or warning message given and it will be a hassle to manually delete the added duplicate lessons.

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: While I agree that users may have their own reasons to duplicate their tasks, there is no good reason to allow users to be able to duplicate lessons. If they mistakenly add duplicate lessons, there is no error or warning message given and it will be a hassle to manually delete the added duplicate lessons.

From the CS2113T PE page:

image.png

and

image.png

Since the lesson data is pulled from the NUSMods API, the values for duplicate lessons are always the same and duplicate detection would be trivial. I would argue that this cannot be classified as NotInScope as it is not hard at all to implement.