search

Chi-teck / drupal-code-generator

A code generator for Drupal.
GNU General Public License v2.0
259 stars 46 forks source link

Commit fails after update to 3.6.0 #158

Open SirClickALot opened 1 month ago

SirClickALot commented 1 month ago

I have just performed a composer update on my local Drupal development site via the CLI and noted that an attempt was made to update to 2.50 from 3.5.0...

Upgrading chi-teck/drupal-code-generator (3.5.0 => 3.6.0)

This appeared to work OK until I tried to commit and then I got a commit error - never seen a commit error before! ...

C:\Users\nick\Sites\bit-by-bit.org\public_html> git.exe add --force --pathspec-from-file=- --pathspec-file-nul C:\Users\nick\Sites\bit-by-bit.org\public_html> git.exe rm --pathspec-from-file=- --pathspec-file-nul pathspec 'vendor/composer/a8af1a19/Chi-teck-drupal-code-generator-7794c26/.github/dependabot.yml' did not match any files

Should I be concerned about this, what does it actually mean? Things might still be fine locally but I am loathed to push this up to PROD in case it knocks it out of action.

Thanks for any advice.

As you can see, I am developing the site on Windows.

Chi-teck commented 1 month ago

I think you can just add everything (git add path/to/dcg) and commit. Also note the commiting vendor packages is not a good idea. Drupal flow recommends deploying vendor directory through composer install command.

SirClickALot commented 1 month ago

Hi, thanks for coming back to me. I did indeed add everything, I always do, literally a git add . I do understand the convention of not committing the vendor folder itself but right now my PROD (although it's not really live) is on very cheep hosting that does not support rebuilding via composer. BUT my real question is WHAT does the massage actually MEAN as I have never in years, seen a local commit fail?

Thanks again.

Chi-teck commented 1 month ago

I don't know what you were trying to achieve by git rm. The message just says you don't have that file locally.

that does not support rebuilding via composer.

You don't have to rebuild packages on prod server. It's possible to build everything locally and upload to remove server through rsync.