Closed AlexGuo1998 closed 1 year ago
Pasting the PR summary here from @AlexGuo1998 ( https://github.com/Chia-Network/bladebit/issues/249#issuecomment-1313442568):
After digging into the code I assume this is a bug.
Length of _mapBitCounts
should be _numBuckets+ExtraBucket
i.e. _numBuckets
, 512. However it's defined as:
Oops.
Anything more than 256 buckets would crash, because uint32 _threadCount
get overridden to an arbitrary large number, making jobs[i]
pointing to an invalid address.
I reviewed it and you are correct, I appreciate the fix! I am surprised that it had worked before in local runs with this bug present.
It seems the commit was made from master
instead of the latest develop
. Can you please rebase your commit from the latest develop
instead of master
since this is supposed to be merged into develop, I need the history to remain linear. Then do a push --force
so that
done
See https://github.com/Chia-Network/bladebit/issues/249#issuecomment-1313442568 for explanation