Chia-Network / bladebit

A high-performance k32-only, Chia (XCH) plotter supporting in-RAM and disk-based plotting
Apache License 2.0
339 stars 109 forks source link

Fix out-of-bounds writesin `BitView::_Read64<true>` #355

Open chiayy-com opened 1 year ago

chiayy-com commented 1 year ago

This fixes #354.

chiayy-com commented 1 year ago

Note: I just noticed there's no test cases for this functionality in the codespace. I did some regression testing manually (fetching proofs / quality) and it works fine, but it still need some serious tests.

(I‘d like to add some, but I'm not sure of when 😂)

harold-b commented 1 year ago

Yes feel free to add a test. BB currently does not have much tests, there's a few for specific cases and commonly re-used objects. But it's mostly used as a sandbox.

You can have a look in Tests.cmake.