Update jsbindings.cpp - Githubissues

Chia-Network / bls-signatures

BLS signatures in C++, using the blst library for BLS12-381

Apache License 2.0

292 stars 211 forks source link

Update jsbindings.cpp #455

Closed BubbleTrouble14 closed 2 months ago

BubbleTrouble14 commented 4 months ago

Changed in the correct place now.

coveralls-official[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 8410371840

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.649%

Totals
Change from base Build 8345515027:	0.0%
Covered Lines:	1645
Relevant Lines:	1738

💛 - Coveralls

emlowe commented 2 months ago

This can't be correct - you change the G2Element to use the G1Element generator?

BubbleTrouble14 commented 2 months ago

This can't be correct - you change the G2Element to use the G1Element generator?

Yes indeed its wrong was supposed to update the G1Element to use the G1Element generator. But hadn‘t got round to then building it and doing it correctly. As when looking at the current implementation the g1 generator returns the G2Element in the types which i assume is incorrect ?

BubbleTrouble14 commented 2 months ago

Location in the generated types as seen here.