search

Chia-Network / chia-blockchain-gui

Chia blockchain GUI in electron/react
https://chia.net
Apache License 2.0
332 stars 246 forks source link

[Bug] Unable to take offers that have a date expiry, even before offer expires. #2386

Closed AbandonedLand closed 1 month ago

AbandonedLand commented 2 months ago

What happened?

When using the (chia rpc wallet take_offer) on an offer with an expire date, I get an error. If I use the GUI to accept the same offer I get conflicting messages.

image

Version

2.3.0

What platform are you using?

Windows

What ui mode are you using?

CLI

Relevant log output

Request failed: RPC response failure: {"error": "This offer is no longer valid", "success": false, "traceback": "Traceback (most recent call last):\n  File \"chia\\rpc\\util.py\", line 49, in inner\n  File \"chia\\rpc\\util.py\", line 118, in rpc_endpoint\n  File \"chia\\rpc\\wallet_rpc_api.py\", line 2009, in take_offer\n  File \"chia\\wallet\\trade_manager.py\", line 782, in respond_to_offer\nValueError: This offer is no longer valid\n"}
AbandonedLand commented 1 month ago

More information:

I created an offer on a Windows 10 machine running Chia 2.3.0. I used the RPC to create an offer that expired in 30 minutes using the "max_time" flag. If I viewed the offer on the same machine it looked correct and was able to be accepted by the wallet. If I opened the offer on a second machine (Windows 10 running Chia 2.1.0) it gave this error.

image

AbandonedLand commented 1 month ago

offer data: offer1qqr83wcuu2rykcmqvpsxygqqemhmlaekcenaz02ma6hs5w600dhjlvfjn477nkwz369h88kll73h37fefnwk3qqnz8s0lle0wz0dj8xy5zlxryt8dgafhzuftusu0x7nlwkwmhcxl88zswfe6dnu23dqzt83lf67wjnjtlk7nllanuy3rnnat4vnaax8jg8mgt6w0c5r4gg38n70ll0udu8zeffqzp4s8kqu0x8aqs4vlxj2a2u9gm4mzvfmc6dtf3y6f869zxhafs0wxa8d4mc4kerpcyvacw2vzxsj8krutar2jn8xme29zcleww69kcnj5pest20c93x7uyq93lydkm0yvkm05wkm05wkmd5wkrfa8kxmdhhg6aaqx9lwp0x0wl2w0rta569ud4hxf4yyms3mrr8tq0xw0tsd3nd3nk94hdr9d2c24tkf09cy6asm2em43va8wep7we5s47akn66530hx5ly7nxvvhwtx6heezad92gzhwrphjyg7mrsqmx7d4kxtjx9ha6xhp8m7vmglvgyej6qz6kknrfuetpy0nuunjcmdlcsjhajnv6vuwne7kt5tcvldl630j8dsq9wfqqtqw0lc0ln0fy9nvwq9unv07hmq4mpt2jp75f64tfaq00sltxykqwryzz24dmncea0tw486m8fvm37s82x2umlsy5cmdlnxwpshmknulah5ljaw6c8uylnr2pt4m2juktr676kpt7h4wvw4p903luzcfx55l7dj4zl7zdtdvqp3ahqur0hactxm2ljx5xaqr0larx4ewf0l8mzze2lflp4uu7sa0drtlfllnv7wllf84sxf5jl79lgruw707wqrpyl0d6wcaycngghu46xwnjm09qlkpsfe7rydhmfyuqfaytwd7rrvfu6lchcsrd38shh36laj2vmap6wtkxqshrhpqk7er6qa5aal8c063r6u6eur5zmgrxsadkllqkzd5m6sewyrrznqfpqccq59cdf8ltg49krfj37rr7lm47awlhr3ed2el2mth7hzqhdaltrvxwmehkwhdsm2jnzu72uy530wg04793tfp33v0azryg79ahh0870z0m56ngghqhftguhvdfhh66mh8e6j2a0rgl5jla7mhsmye0kadhxn660k3anhfyrsqp7ey27q2kvn9p

AbandonedLand commented 1 month ago

UPDATE: Resetting (closing and reopening) my wallet resolved this issue.

markelrod commented 1 month ago

Transferred this enhancement request to the GUI repo. Team discussed improving the messaging in the UI so that it is clear why the offer is no longer valid (accepted) and not only the fact that it expires in the future.

wjblanke commented 1 month ago

Should fixed in 2.4.0rc1