Chia-Network / chia-blockchain

Chia blockchain python implementation (full node, farmer, harvester, timelord, and wallet)
Apache License 2.0
10.82k stars 2.03k forks source link

[Enhancement] Running just a full node should not force keyring unlock #10268

Closed ojura closed 2 years ago

ojura commented 2 years ago

What happened?

If one wishes to run only the full node (chia start node), the daemon prompts for the keyring password. This is not necessary for operating a full node, and should be only asked when starting up wallet/farmer.

Version

1.3 beta

What platform are you using?

Linux

What ui mode are you using?

CLI

Relevant log output

No response

ojura commented 2 years ago

Mitigation: First, ensure that the legacy Python plaintext keyring has been cleared for greater security.

The full node can be started with CHIA_PASSPHRASE_SUPPORT=false chia start node which avoids having to unlock the keyring. (Note that in order to be able to run the wallet, the daemon along with the full node has to be shut down and launched without disabled passphrase support.)

github-actions[bot] commented 2 years ago

This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.

ojura commented 2 years ago

The latest 1.3 beta still does this

github-actions[bot] commented 2 years ago

This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.

github-actions[bot] commented 2 years ago

This issue was automatically closed because it has been flagged as stale, and subsequently passed 7 days with no further activity from the submitter or watchers.