search

Chia-Network / chia-blockchain

Chia blockchain python implementation (full node, farmer, harvester, timelord, and wallet)
Apache License 2.0
10.82k stars 2.03k forks source link

Add offer status in check_offer_validity response #13706

Closed LCG22 closed 1 year ago

LCG22 commented 1 year ago

Discussed in https://github.com/Chia-Network/chia-blockchain/discussions/10079

Originally posted by **mikehw** February 3, 2022 It would be useful to have the offer's status (e.g. accepted vs canceled) returned in the `check_offer_validity` response. This way the offer does not need to be in the wallet's `trade_manager` to determine if the offer was accepted vs canceled. This is useful for deploying an offer record-keeping system in a micro-service architecture where there isn't a single chia wallet that has all of the offers loaded into the trade manager.
trepca commented 1 year ago

If you're building a microservice, it might be better to use full node directly to examine offers vs wallet and track the chain for any acceptances: https://developers.chia.net/t/examining-offers-from-an-explorer-perspective/644

github-actions[bot] commented 1 year ago

This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.

github-actions[bot] commented 1 year ago

This issue was automatically closed because it has been flagged as stale, and subsequently passed 7 days with no further activity from the submitter or watchers.