It appears we no longer honor setting uPnP=false in config.yaml

Chia-Network / chia-blockchain

Chia blockchain python implementation (full node, farmer, harvester, timelord, and wallet)

Apache License 2.0

10.82k stars 2.03k forks source link

It appears we no longer honor setting uPnP=false in config.yaml #501

Closed hoffmang9 closed 4 years ago

hoffmang9 commented 4 years ago

https://github.com/Chia-Network/chia-blockchain/blob/8a13535937d70eb58c50409dca2e2f42c43231aa/src/server/start_service.py#L111

End users must be able to disable uPnP as some wish to run two nodes behind one SMB/SOHO router.

wjblanke commented 4 years ago

https://github.com/Chia-Network/chia-blockchain/pull/522

Jonas-ben commented 3 years ago

can you explain that again

because in line 111 i have : self .upnp: Optional[UPNP] = None in Line 130: for port in self ._upnp_ports: if self .upnp is None: self .upnp = UPnP() in Line 196: for port in self ._upnp_ports: if self .upnp is not None: self .upnp. release(Port) Which line do i have to edit