Chia-Network / chia_rs

Rust crate & wheel with consensus code
Apache License 2.0
19 stars 24 forks source link

Fix pymethods by moving outside of pybindings modules #583

Closed Rigidity closed 2 months ago

Rigidity commented 2 months ago

There is a bug in pyo3 (or at least, it seems like a bug), that prevents methods defined in pymethods from being visible to Python if they are defined within a different module (with a #[cfg(feature = "py-bindings")], notably).

coveralls-official[bot] commented 2 months ago

Pull Request Test Coverage Report for Build 9645001858

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-bls/src/public_key.rs 22 25 88.0%
crates/chia-bls/src/secret_key.rs 4 19 21.05%
<!-- Total: 107 125 85.6% -->
Totals Coverage Status
Change from base Build 9598048861: 0.0%
Covered Lines: 11680
Relevant Lines: 14108

💛 - Coveralls