coveralls-official[bot]
commented
3 months ago Pull Request Test Coverage Report for Build 9836286700
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+1.9%) to 82.688%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| crates/chia-consensus/src/gen/conditions.rs | 2 | 99.45% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 9785517758: | 1.9% |
| Covered Lines: | 11554 |
| Relevant Lines: | 13973 |
This PR is best reviewed one commit at a time, as the flags are fairly independent.
Now that the hard fork has activated, some feature flags are no longer necessary (as they are always enabled).
ENABLE_SOFTFORK_CONDITION,AGG_SIG_ARGSandCOND_ARGS_NIL- these features are always-on now.The change around
AGG_SIG_ARGSandCOND_ARGS_NILis probably the least obvious. Before the hard fork,AGG_SIG_MEandAGG_SIG_UNSAFErequired exactly two arguments (as opposed to all other conditions, that allow unknown arguments). WhenAGG_SIG_ARGSis set (as it is after the hard fork activation), theAGG_SIG_MEandAGG_SIG_UNSAFEconditions behave like the others. This is why the special cases can be removed inconditions.rs, here.