remove special case for `G1Element` in `SExp.to()`

Chia-Network / clvm

[Contract Language|Chia Lisp] Virtual Machine

Apache License 2.0

86 stars 35 forks source link

remove special case for `G1Element` in `SExp.to()` #134

Closed arvidn closed 1 year ago

arvidn commented 1 year ago

Instead support any type that can convert to bytes.

coveralls-official[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5877680554

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.345%

Totals
Change from base Build 4176492396:	0.0%
Covered Lines:	916
Relevant Lines:	951

yeah, as far as I can tell, in all situations we use this in chia-blockchain right now, the types of the list is erased already anyway. So in practice it's not a regression (yet). I suppose we would need to export a protocol that we could use in chia-blockchain as well, as the member of our List[x]

Chia-Network / clvm

remove special case for `G1Element` in `SExp.to()` #134

Pull Request Test Coverage Report for Build 5877680554

💛 - Coveralls