Chia-Network / clvm_rs

Rust implementation of clvm
Apache License 2.0
67 stars 57 forks source link

Remove clvm-traits and bump chia-bls #368

Closed Rigidity closed 7 months ago

Rigidity commented 7 months ago

There is a circular dependency issue still, whenever we bump clvm-traits. Since the implementations here are for the old version, the new version is a conflict, which causes errors in chia_rs. The simplest path forward is to remove the circular dependency between repos wherever possible. So this reverts a prior change to add it.

This is a breaking change, and to implement it in chia_rs, we will have to add the implementations back, as well as a dependency on clvmr in clvm-traits. This also means that chia-bls cannot depend on clvm-traits since it would indirectly depend on itself in doing so.

coveralls-official[bot] commented 7 months ago

Pull Request Test Coverage Report for Build 7759447098


Totals Coverage Status
Change from base Build 7726608167: -0.05%
Covered Lines: 5221
Relevant Lines: 5578

💛 - Coveralls