Closed Rigidity closed 8 months ago
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
wasm/src/lazy_node.rs | 0 | 1 | 0.0% | ||
src/runtime_dialect.rs | 0 | 3 | 0.0% | ||
src/allocator.rs | 135 | 142 | 95.07% | ||
<!-- | Total: | 211 | 222 | 95.05% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/allocator.rs | 2 | 98.37% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 7837886158: | -0.1% |
Covered Lines: | 5756 |
Relevant Lines: | 6100 |
This PR changes the way
a.atom(ptr)
works to return anAtom
type that can convert small integers to byte slices. This prevents a memory safety issue on the edge case where you exceed the temp vec length and references are left dangling.Overall, the performance is actually improved slightly for the majority of benchmarks.