Chia-Network / clvm_tools

Tools for clvm development
Apache License 2.0
51 stars 32 forks source link

version issue in 0.4.3 and test isn't written for setup.py? #61

Open risner opened 3 years ago

risner commented 3 years ago

Here is a patch that fixes a compile issue that makes it not able to find clvm_tools in chia-blockchain-1.1.6:

--- pyproject.toml.orig 2021-05-30 14:12:11.254703000 -0400
+++ pyproject.toml  2021-05-30 14:11:35.404486000 -0400
@@ -3,5 +3,5 @@
 requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.4"]

 [tool.setuptools_scm]
-fallback_version = "unknown"
+fallback_version = "0.4.3"
 local_scheme = "no-local-version"
risner commented 3 years ago

Also python3 setup.py test errors out: File "/usr/local/lib/python3.8/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule tests.append(self.loadTestsFromName(submodule)) File "/usr/local/lib/python3.8/unittest/loader.py", line 205, in loadTestsFromName test = obj() TypeError: patch_build_ext() missing 1 required positional argument: 'build_ext'

richardkiss commented 3 years ago

The version issue is due to setuptools_scm, a handy but sometimes painful build tool which gets the version from the git log at build time. Setting the fallback_version is a good workaround for the FreeBSD port, but sort of defeats the purpose of using setuptools_scm in the first place.

And yeah, python setup.py test doesn't work with our setup.py at the moment. Use py.test tests.