search

Chiang-HuiXin / pe

0 stars 0 forks source link

List Command still work when additional invalid parameters are added #17

Open Chiang-HuiXin opened 2 weeks ago

Chiang-HuiXin commented 2 weeks ago

image.png

The command should not work when user type in invalid inputs for example when i input list invalid the command still works.

nus-pe-bot commented 2 weeks ago

Team's Response

Thank you for the input ! However, in accordance with the guidelines given in the course website (refer to the screenshot given below), we intentionally designed our commands' parsing logic in such a way that it does not block inputs like the one you gave. We predicted that such extra characters being input after the list command keyword do not hinder our operations in any way as they are simply removed by our parsing logic and thus, we do not really consider it to be an invalid input, just a command with some extraneous input that is ignored. In certain rare occurrences where the user might enter an additional character after the list command keyword by mistake, we did not want to block the user from being able to see the listed internships simply because of this typo as this may annoy the user (refer to the 2nd highlighted point of the screenshot given below). Furthermore, the course website has mentioned that this lack of proper handling (such as blocking or warning) is only a feature flaw in case of invalid inputs. However, since we don't consider this input to be an invalid one (as long as the first word which is the list command keyword is properly typed), we did not really feel the need to have any message be displayed to the user to tell them that they have input extra characters which are not required. However, we do agree that displaying an additional warning message to point out in such cases (followed by the listed internships' output that we have right now), could probably make the usage of this command more intuitive and help prevent the user from entering any extraneous characters from next time onwards. For this reason, I will mark this issue as NotInScope for this version of our app but we could definitely consider your input and maybe display an additional warning message from the next version of our app onwards. Thank you ! image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]