Chiarena / pe

0 stars 0 forks source link

Allows adding of invalid email #2

Open Chiarena opened 5 months ago

Chiarena commented 5 months ago

image.png An invalid email that is not followed by a ".com" is allowed to be added. Can be problematic since most emails have a .com

nus-se-script commented 5 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi, Thank you for your kind feedback! We intentionally did not set overly strict email constraints because allowing such flexibility can in turn allow the user to use the software in different ways while overzealous rejection of inputs can annoy the user. For example, some TAs might wish to contact with their students via other domain names, for e.g, axelteo@comp.nus.edu.sg, It is not necessary for an email to end with .com as shown in earlier example. Furthermore, our documentation mentions that it is up to the User to ensure that the email is valid.

telegram-cloud-photo-size-5-6136195526866093558-x.jpg

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]