Chiarena / pe

0 stars 0 forks source link

Invalid phone number allowed #5

Open Chiarena opened 2 months ago

Chiarena commented 2 months ago

image.png A four number phone number is allowed to be added which may not be a valid phone number.

image.png

image.png A very long phone number is also allowed which is also likely an invalid phone number

nus-se-script commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for the suggestion. It is impossible to design phone constraints that can perfectly validate/ invalidate every possible phone number due to NUS having exchange students from all over the world.

We deliberately did not enforce too many constraints for phone numbers. This is because allowing such flexibility can in turn allow the user to use the software in different ways while overzealous rejection of inputs can annoy the user. For example, this may allow users to store contact numbers of exchanges from different countries, like Niue, which only has 4 digits. Whereas excessively long phone numbers as inputs can only happen in case of deliberate sabotage, so it is not a bug. Therefore, the benefits of allowing these inputs of different length numbers outweighs being overzealous in our constraints.

Furthermore, Prof Damith mentions here that extreme user behaviour is not considered a bug.

telegram-cloud-photo-size-5-6136195526866093552-x.jpg

Regardless, this will not hinder the operations of the application in any way.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]