search

ChibiOS / ChibiOS-Contrib

Community contributed code (ports, drivers, etc).
130 stars 227 forks source link

Bug in hal_fsmc.h #227

Open sabdulqadir opened 4 years ago

sabdulqadir commented 4 years ago

First of all, Thanks to @barthess, @fpoussin, and everyone else who contributed to providing NAND flash driver. I recently tried moving from 18.2.0 to 20.3.2 and had following issues:

  1. For ChibiOS-Contrib/os/hal/include/hal_fsmc.h:37 => needs to include stm32f7x targets

  2. Also line324 on the same file has a typo "STM32_NAND_USE_NAND1" instead of "STM32_NAND_USE_NAND2"

  3. Should dmaStreamAlloc(nandp->dma, be=> nandp->dma = dmaStreamAlloc(STM32_NAND_DMA_STREAM,

If you guys deem it suitable, I can make these changes and do a pull request.

Thanks, AQ

ChibiOS version: 20.3.2 Compiler: arm-none-eabi-gcc (7-2018-q2-update)(7.3.1) Platform and board:STM32F723ZE (custom board) Nature of the problem: Cannot compile Failure mode: n/a

fpoussin commented 3 years ago

Hi @sabdulqadir, feel free to send in a pull request, that would help us. Thanks!