search

Chicago / RSocrata

Provides easier interaction with Socrata open data portals http://dev.socrata.com. Users can provide a 'Socrata' data set resource URL, or a 'Socrata' Open Data API (SoDA) web query, or a 'Socrata' "human-friendly" URL, returns an R data frame. Converts dates to 'POSIX' format. Manages throttling by 'Socrata'.
https://CRAN.R-project.org/package=RSocrata
Other
236 stars 84 forks source link

Failing CRAN checks - due 10/16 #183

Closed nicklucius closed 4 years ago

nicklucius commented 5 years ago

https://cran.r-project.org/web/checks/check_results_RSocrata.html

geneorama commented 4 years ago

RSocrata was pulled off CRAN, this time they didn't give much warning, just one email on 10/2.

The only failing test I see is documented as relating to issue #118, line 131 of the test script. The data set is returning 146 columns instead of 150.

Edit: I linked to the test, the actual failing part is this part expect_equal(150, ncol(dfCsv), label="columns", info="https://github.com/Chicago/RSocrata/issues/118")

geneorama commented 4 years ago

Also, the link to the CRAN checks is no longer available, so I can't confirm that the errors I'm seeing are the same that they were seeing https://cran.r-project.org/web/checks/check_results_RSocrata.html

nicklucius commented 4 years ago

Changing the expected number of columns to 146 fixes the issue and all tests pass. Socrata changed the number of columns in this dataset. Since the test itself is unrelated to the number of columns, I think the fact that the test now passes means that the breakage is resolved and we should resubmit to CRAN.

I'll start another issue to investigate the column number change as well as other inconsistencies reported by @geneorama in #118.

nicklucius commented 4 years ago

We are now passing CRAN checks and have submitted the package to be back on CRAN.