search

Chicago / RSocrata

Provides easier interaction with Socrata open data portals http://dev.socrata.com. Users can provide a 'Socrata' data set resource URL, or a 'Socrata' Open Data API (SoDA) web query, or a 'Socrata' "human-friendly" URL, returns an R data frame. Converts dates to 'POSIX' format. Manages throttling by 'Socrata'.
https://CRAN.R-project.org/package=RSocrata
Other
236 stars 83 forks source link

Fixes #183 #185

Closed nicklucius closed 5 years ago

nicklucius commented 5 years ago

Due to a change in an upstream data source, test code had broken. This fixes that code.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.5%) to 83.784% when pulling 527a34e874cde0e9eb54792f6748e5e6e3f6afcc on issue183 into 8befd4fceda620ba7d4322e33fae1ab29a27d895 on master.

geneorama commented 5 years ago

I'm more inclined to remove the column count tests unless we can comment why they're relevant.

I would also like to add some additional comments about what these tests are doing.

nicklucius commented 5 years ago

@geneorama I think we will have a better answer about the column questions when we resolve #184. The test description is "Warn instead of fail if X-SODA2-* headers are missing" and we could add to that after resolving #184 as well.

If you want to remove the column checks while #184 is open I don't see an issue with that.

geneorama commented 5 years ago

@nicklucius can you review please?

Made changes based on our conversation. I don't think the checks for data frame or column numbers were related to the original issue. The column number check was the part that was failing, so to me the cleanest way is to adjust the test.

geneorama commented 5 years ago

Based on the verbal discussion, good idea to add the message relating to issue 118

nicklucius commented 5 years ago

Looks good @geneorama

geneorama commented 5 years ago

@nicklucius thanks. Glad we could get this knocked out.