Chicago / clear-water

Forecasting elevated levels of E. coli at Chicago beaches to provide proper warning to beach-goers.
http://chicago.github.io/clear-water
55 stars 43 forks source link

Wave heights in the negatives #124

Closed CallinOsborn closed 7 years ago

CallinOsborn commented 7 years ago

Coming in off of the data portal, probably because of some sort of programming/battery thing we are getting wave heights in the negatives.

image

As fun as it would be to imagine what negative waves would look like, they are not supposed to be that way, the negatives need to be changed to a 0.

This is also the same problem in wave period. As of this writing there are 526 total wave heights and periods that are negative of over 32,000 observations. But if we change them all to zeros it is effectively changing them to NAs because there is no exactly perfect 0.000

image

Which is also the same for the wave period

image

I really don't see this as being an issue trying to fill in the NAs in the future.

CallinOsborn commented 7 years ago

Fix is #125