search

Chicago / clear-water

Forecasting elevated levels of E. coli at Chicago beaches to provide proper warning to beach-goers.
http://chicago.github.io/clear-water
55 stars 43 forks source link

Clean-up "challenge" page #145

Closed tomschenkjr closed 7 years ago

tomschenkjr commented 7 years ago

Need to clean-up the challenge page a bit. Below are some tasks and the point-of-contact. Check them off once they are finished.

This could potentially have a lot of merge conflicts. Just ping this thread when you start work and I'll hold-off so we don't spend all day fixing the conflicts.

nicklucius commented 7 years ago

@tomschenkjr - Sounds good. The home repo for the Shiny App is https://github.com/rchesak/Chicago-Beaches. I wanted to ask for thoughts on storing my tweaks. Right now they are only on the EC2 server. Maybe fork the project to our GitHub?

tomschenkjr commented 7 years ago

Yes, let’s fork it over to Chicago. Be sure to keep the original licensing since it’s required of the MIT license.

From: Nick Lucius [mailto:notifications@github.com] Sent: Friday, August 04, 2017 12:02 PM To: Chicago/clear-water clear-water@noreply.github.com Cc: Schenk, Tom Tom.Schenk@cityofchicago.org; Mention mention@noreply.github.com Subject: Re: [Chicago/clear-water] Clean-up "challenge" page (#145)

@tomschenkjrhttps://github.com/tomschenkjr - Sounds good. The home repo for the Shiny App is https://github.com/rchesak/Chicago-Beaches. I wanted to ask for thoughts on storing my tweaks. Right now they are only on the EC2 server. Maybe fork the project to our GitHub?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/clear-water/issues/145#issuecomment-320300989, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0YHyf_RDIIxr8frehHjc5DC1sozgks5sU06fgaJpZM4Ot8H5.

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

tomschenkjr commented 7 years ago

I've created a branch, issue145 for this. I'm beginning work on it so you may not want to touch anything on this issue, yet.

nicklucius commented 7 years ago

Sounds good, I'll hold off. But I did complete the Shiny app license language task, since it's a different repo.

tomschenkjr commented 7 years ago

@nicklucius - thanks on the Shiny app. Actually, can you just link to the MIT license (in our repo) in the text instead of the full thing?

nicklucius commented 7 years ago

Sure thing, will do.

From: Tom Schenk Jr [mailto:notifications@github.com] Sent: Friday, August 04, 2017 12:42 PM To: Chicago/clear-water clear-water@noreply.github.com Cc: Lucius, Nicholas Nicholas.Lucius2@cityofchicago.org; Mention mention@noreply.github.com Subject: Re: [Chicago/clear-water] Clean-up "challenge" page (#145)

@nickluciushttps://github.com/nicklucius - thanks on the Shiny app. Actually, can you just link to the MIT license (in our repo) in the text instead of the full thing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/clear-water/issues/145#issuecomment-320310202, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQEqM2u64gUwt9Js9fa60vBquNWf7K9iks5sU1fegaJpZM4Ot8H5.

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

tomschenkjr commented 7 years ago

@nicklucius - thanks, looks great.

I've pushed changes back to issue145 branch. When you get a chance, you can add your bits. I'm done working on it for a moment.

nicklucius commented 7 years ago

Left out the issue # in my commit message: https://github.com/Chicago/clear-water/commit/28af49f9c4a8c97303c0f499070729e7ac529a83

tomschenkjr commented 7 years ago

Looked at the nav bar on the challenge page and realized it may not make sense to include the seal since the nav does not follow along the page. Closing this issue for now.