Chicago / design-cds-bootstrap

The Chicago Design System as a Bootstrap 4 theme
https://chicago.github.io/design-cds-bootstrap/
MIT License
8 stars 2 forks source link

UI - Update link & button colors that use Flag Blue #25

Closed jdkunesh closed 4 years ago

jdkunesh commented 4 years ago

Today we often use Flag Blue with white text, or Flag Blue text on a white background. These are not accessible and should be changed.

Please:

alaeder16 commented 4 years ago

@jdkunesh Just to be clear - I will bring the Malibu up to the Primary colors and then will apply to all the links or buttons. Also we need to add the color reference name to the styles. And one more - we are not referencing the US web styles, correct? As soon I'm done with re-skinning it in figma @mario-duran will make adjustments to the code.

jdkunesh commented 4 years ago

Hi @alaeder16–

Yes. @mario-duran please work with Anna to add the color reference names as mentioned, both in Bootstrap & on her work in Figma.

Let's put Flag blue in a separate category: Primary, Secondary, Heraldry. Flag Red & Blue should go in Heraldry. Eventually we would add the Seal colors as well.

I am not sure what you mean by referencing the styles? The work now should be to port the UDWDS style/design choices to the equivalent Bootstrap component, feel free to give me a call or hit me up in Teams or what not to chat. Thanks!!

alaeder16 commented 4 years ago

@jdkunesh 10-4

alaeder16 commented 4 years ago

@mario-duran I updated the Figma. Please use it as color reference in Bootstrap.

mario-duran commented 4 years ago

Perfect, I will @alaeder16

mario-duran commented 4 years ago

Updated all the colors in the variables.scss and made sure it matches as expected