class text-white has an incorrect name

Chicago / design-cds-bootstrap

The Chicago Design System as a Bootstrap 4 theme

https://chicago.github.io/design-cds-bootstrap/

MIT License

8 stars 2 forks source link

class text-white has an incorrect name #26

Closed chrisjcalderon closed 4 years ago

chrisjcalderon commented 4 years ago

Somehow the text-white class is not being compiled correctly and instead a class:

.text-#fff { color: #fff !important } is added to the dist output.

jdkunesh commented 4 years ago

Hi @chrisjcalderon-

Where are you seeing that? I don't have a /dist/ folder currently?

chrisjcalderon commented 4 years ago

@jdkunesh

https://chicago.github.io/design-cds-bootstrap/

you will notice elements that with a text-white class don't show correctly

the gitub page uses this style https://chicago.github.io/design-cds-bootstrap/assets/css/styles.css

jdkunesh commented 4 years ago

Locally, I have no issues. It looks like an error in how SASS is being generated on the server. I also made some additional accommodations– pulling the latest v.4.3.1 tag of Bootstrap, etc.

Within 30 minutes we'll see how the server builds work.

Locally, the SASS processes just fine. 🤔

jdkunesh commented 4 years ago

It looks like minification is introducing an error, as I am now able to reproduce this locally. Thanks again for the catch!

jdkunesh commented 4 years ago

https://github.com/Chicago/design-cds-bootstrap/blob/master/_config.yml

Apparently, Jekyll doesn't like SASS Compressed for some reason.

For now, I went with SASS compact, which puts each rule on its own line. See https://sass-lang.com/documentation/cli/ruby-sass#style I am not sure why compressed forces a different issue. My guess is that there is a character that is causing minification to error. ¯_(ツ)_/¯

For now, it works and we can add an issue to investigate.