Chicago / design-cds-bootstrap

The Chicago Design System as a Bootstrap 4 theme
https://chicago.github.io/design-cds-bootstrap/
MIT License
8 stars 2 forks source link

UX- Header nav component #34

Closed alaeder16 closed 4 years ago

alaeder16 commented 4 years ago

Review Figma file & bootstrap default styles Update Figma to reflect CDS colors & look, Bootstrap functionality blue box, red star, CHICAGO in text, Mayor Lori E. Lightfoot as subtext mobile-friendly: It should shrink effectively at mobile sizes. review headers in Figma update Figma mobile, tablet & desktop component views.

chrisjcalderon commented 4 years ago

Question for all: As the navigation, footer and other USWDS elements are styled in boostrap:

Will the usa- class prefix be removed in favor of a coc class prefix or perpahs something more generic i.e. site-footer, site-nav, etc?

mario-duran commented 4 years ago

I like the idea of having a coc prefix to make sure the Chicago design system styles do not interfere with any other style already in use.

Currently I am still using usa- in the EDS implementation but I was thinking on changing that to cds- on this project.

Please let me know your thoughts

On Wed, Nov 20, 2019 at 3:00 PM Christian Calderon notifications@github.com wrote:

Question for all as the navigation, footer and other USWDS elements are styles in boostrap:

will the usa- class prefix be removed in favor of a coc class prefix or perpahs something more generic i.e. site-footer, site-nav, etc?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Chicago/design-cds-bootstrap/issues/34?email_source=notifications&email_token=ABYMNRMQNEI5KVLBCNA2DFDQUWQPFA5CNFSM4JPIGOIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEU5FSY#issuecomment-556389067, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYMNRIWNI36Z5CJHIVXKPLQUWQPFANCNFSM4JPIGOIA .

chrisjcalderon commented 4 years ago

cds should work well. Also, we need to use hierarchy as much as possible so we use things like

cds-nav-link, but instead .nav.cds-nav li.nav-link { ...}

it will make it much more maintainable and easier to override when needed,

alaeder16 commented 4 years ago

Figma is updated