Space between main content last paragraph and footer

dpmesa commented 4 years ago

In the current apps that implement the new CDS (eds & eforms) the last paragraph on the main content seems to be too close the the footer -see attached image. Should we consider adding a margin-top on the footer so there is a little bit more separation?

jdkunesh commented 4 years ago

Yes.

dpmesa commented 4 years ago

In the eforms app we added "margin-top: 100px;" on the footer -see below. Is that a good number? More/less?

chrisjcalderon commented 4 years ago

I suggest using bootstrap classes and not pixel margins - i.e. mt-<1 2 3 4> , or whatever is necessary)

On Thu, Jan 9, 2020 at 11:16 AM Diego A. Perez Mesa < notifications@github.com> wrote:

In the eforms app we added "margin-top: 100px;" on the footer -see below. Is that a good number? More/less?

[image: image] https://user-images.githubusercontent.com/12786488/72089257-5000ba00-32d1-11ea-83a5-e8ceecda28d6.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Chicago/design-cds-bootstrap/issues/59?email_source=notifications&email_token=AAQEDGIMNZFYPF5OYSOW2SDQ45LYLA5CNFSM4KEPUXZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIRCHVY#issuecomment-572662743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQEDGOCGVM36J4P4QX4ZHLQ45LYLANCNFSM4KEPUXZA .

-- -- Christian Calderon

jdkunesh commented 4 years ago

@chrisjcalderon beat me to the answer. When in doubt, check the framework first. @mario-duran (FYI)

Thanks for flagging this, @dpmesa! Sorry the first response was terse- my email github fu in the morning is not great.

mario-duran commented 4 years ago

I added a "mt-4" into the main template of all our example pages and the main footer component

Chicago / design-cds-bootstrap

Space between main content last paragraph and footer #59