search

Chicago / food-inspections-evaluation

This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.
http://chicago.github.io/food-inspections-evaluation/
Other
410 stars 130 forks source link

Remove str() outputs from 10_download_data.R #13

Closed tomschenkjr closed 9 years ago

tomschenkjr commented 10 years ago

See comment https://github.com/Chicago/food-inspections-evaluation/pull/11/files#r20760678

geneorama commented 10 years ago

Go ahead and remove them or I can.

geneorama commented 10 years ago

Actually, I really like having that in there. You want to know what you downloaded when you get to the end of the script. Otherwise what should you do? Write in business logic to make sure you got what you expected?

I created a branch SHA: 5dd6a9da97786ebcf9d90838748e9b15d37714fa named iss10 but I'm inclined to keep str in there once at the end.

tomschenkjr commented 10 years ago

It's worthwhile to think how this code might be run once released. Should we create a script which launches all the code or do we envision this code being ran incrementally (file-by-file) or line by line? If the latter, it makes sense to keep str() and other terminal output. If the former, it makes more sense to suppress terminal output as things will just shoot out without much sense.

Thoughts?

geneorama commented 10 years ago

I'm not sure which way is best. I would like to break out the logic into more pieces. But if we have a piece like "calculate history" I don't know if that should be a script or function. It seems weird to make it a function to me, since it's not generalizable, but it seems unfinished to leave it as a script.

To me, functions make sense when they may have a life outside of a single call. But maybe that's just my perception On Nov 25, 2014 6:44 PM, "Tom Schenk Jr" notifications@github.com wrote:

It's worthwhile to think how this code might be run once released. Should we create a script which launches all the code or do we envision this code being ran incrementally (file-by-file) or line by line? If the latter, it makes sense to keep str() and other terminal output. If the former, it makes more sense to suppress terminal output as things will just shoot out without much sense.

Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/Chicago/food-inspections-evaluation/issues/13#issuecomment-64497827 .

geneorama commented 9 years ago

I commented out the str calls in issue 13. I had forgotten about issue 10 Multiple small changes like this in issue 13