search

Chicago / food-inspections-evaluation

This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.
http://chicago.github.io/food-inspections-evaluation/
Other
410 stars 130 forks source link

Fix sloppy weather code in 12 merge #32

Closed geneorama closed 9 years ago

geneorama commented 9 years ago

The weather data is being read in at the start of the file, but then overwritten later on with a combination of weather and weather_new.

Although there is not a problem with the functionality, this is bad practice and should be fixed. The right thing would be to keep the objects separate (e.g. use weather_old and weather_new then combine them into weather), or at least combine them right after reading them in.

geneorama commented 9 years ago

Hopefully we should get a new weather import which will eliminate this problem entirely!

geneorama commented 9 years ago

Superseded by #38