Chicago / food-inspections-evaluation

This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.

http://chicago.github.io/food-inspections-evaluation/

Other

411 stars 130 forks source link

Banner image does not display on iOS devices #40

Closed tomschenkjr closed 9 years ago

tomschenkjr commented 9 years ago

Confirmed on iPad and iPhone. Appears to be a problem with the type of effect I'm using for parallax. Some documentation points out the use of jQuery is better, so will explore those options.

SEV2014 commented 9 years ago

1/22/15 Team sprint planning: To be included sprint3

tomschenkjr commented 9 years ago

Handing this over to @skishchampi to look at. The library Stellar.js seems to be the suggested solution, have not had time to figure it out.

skishchampi commented 9 years ago

finally...

tomschenkjr commented 9 years ago

Beautiful...well-deserved :+1: and you definitely deserve the satisfaction of closing this issue.

skishchampi commented 9 years ago

But I don't have iPad here. Also, This is optimized for iphone 4 (320*480). Will go find a few more devices (iphone 6 may be) and test it on them before I close it...

The most obscure issue here was how Safari looks at JPG encoding. It doesn't render images if they have been "progressively" encoded. So I just pushed a PNG to the repo. Which was a major relief.
For whatever reason the top and left attributes which work great at 50% on other browsers need 20% and 2% value for them to work on Safari. I hate Apple.
Before I confidently close this issue, I just want to see the site on ipad or something.

tomschenkjr commented 9 years ago

10-4. @SEV2014 do you have an iPad to test http://chicago.github.io/food-inspections-evaluation/ ?

I just checked on Android phone and it works well.

tomschenkjr commented 9 years ago

[x] Note to self (@tomschenkjr) that I need to swap the Futura font stack to a "League Spartan", "Avenir Black", "futura_md_btbold", sans font stack for h1. The overshoots look odd and isn't consistent with the typeface used on the tech plan.

SEV2014 commented 9 years ago

@tomschenkjr - I do not have an iPad to test.

tomschenkjr commented 9 years ago

@SEV2014 - thanks, no problem.

@skishchampi - swing-by when you get in. Rod has an iPad to test.

skishchampi commented 9 years ago

IE has its own set of issues.

ieproblem

ieproblem2

@tomschenkjr The shrink issue has been solved. Was caused by a fixed max-width parameter.

Will now focus on the problem with responsive text alignment.

skishchampi commented 9 years ago

@tomschenkjr This is still risky as it is optimized for the ipad I had today. I am guessing the text will go out of control in iphone 6 plus or the larger ipad.

One quick fix is to use a ton of media queries.

By and large it is fine. But I can keep taking a look at it as and when more devices show up.

Kitchen article position should not be absolute. But I haven't a fix that will work everywhere. Fixing for Safari breaks Chrome, Mozilla et al

SEV2014 commented 9 years ago

@skishchampi - Aakash - can you please advise if this item is ready to close as of 2/11/15 end of day?