search

Chicago / food-inspections-evaluation

This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.
http://chicago.github.io/food-inspections-evaluation/
Other
410 stars 130 forks source link

Removed non-existent dependency and updated docs #86

Closed cash closed 8 years ago

cash commented 8 years ago

The RSocrata branch referenced in the install script no longer exists. You get the error:

Downloading GitHub repo chicago/RSocrata@sprint7
from URL https://api.github.com/repos/chicago/RSocrata/zipball/sprint7
Error in download(dest, src, auth) : client error: (404) Not Found

In addition, it looks like the updates to read.socrata that the download scripts depend on were never integrated into master.

Because the data already exists, I removed the install of RSocrata and updated the main readme to make it explicit that all that needs to be done to reproduce the results is run the install and glmnet scripts.

You might also consider moving the download scripts into an archive directory under CODE since they no longer work.

Note: vim added a new line character at the end of the file which is why the Acknowledgements changed.

geneorama commented 8 years ago

@cash Thank you.

You're right that the dependency needs to be changed, but the code also needs to be updated to reflect the dependency change. I opened an issue #88 for this and (unless you want to take a stab at it) I'll be working on it next.

cash commented 8 years ago

I'll take a look at this. Do you want the scripts to pull down the same data as before? I haven't looked at the Socrata API, but I assume I can apply a time filter.

geneorama commented 8 years ago

Good question.

Ideally I would like the script to download unfiltered data with respect to time, in case we / the user ever wants do something with more recent data.

However, I would prefer not to update the historical data so that there are not small, pointless changes which could cause confusion.

So, I was hoping that the new data would be similar to the old.

I was going to work on this today.

cash commented 8 years ago

If you are working on it, I'll wait. I wouldn't have gotten to it this week.

geneorama commented 8 years ago

I did the work in another branch iss88_rsocrata and opened a pull request for @tomschenkjr to review.

I just noticed that I didn't incorporate your changes to README.md, but I want to tweak the language anyway.

Thank you for bringing the dependency change to our attention.