Chicago / lead-safe-api-docs

http://dev.cityofchicago.org/docs/lead-safe/
1 stars 1 forks source link

v0.5.0 #20

Closed tomschenkjr closed 6 years ago

tomschenkjr commented 6 years ago

API

Application Form

Clinical Content

After reviews have approved this request, I will only merge the request when we've pushed v0.5.0 into production.

tomschenkjr commented 6 years ago

@RaedMan - Please review the terms of service again for any issues.

There is one obvious sentence that needs clarifying:

The risk score, defined as (XXXXXXXXXXX) will be sent to health centers through electronic health records (EHR) and physicians will have the opportunity[...]

however, we will fix that when we release v0.6.0 of the API.

geneorama commented 6 years ago

I noticed a broken link in the notes of the main page, the https is missing the "h"

[^1]: Potash _et al._ (2015) [Predictive Modeling for Public Health](ttps://dssg.uchicago.edu/wp-content/uploads/2016/01/p2039-potash.pdf). _Proceedings of the 21th ACM SIGKDD International Conference on Knowledge Discovery and Data Mining_ pp. 2039-2047.

should be

[^1]: Potash _et al._ (2015) [Predictive Modeling for Public Health](https://dssg.uchicago.edu/wp-content/uploads/2016/01/p2039-potash.pdf). _Proceedings of the 21th ACM SIGKDD International Conference on Knowledge Discovery and Data Mining_ pp. 2039-2047.
geneorama commented 6 years ago

Talked to @tomschenkjr and sounds like @RaedMan is working on the eligibility form, but for now the link is blank in the Eligibility section. Do we want to put in note that it's under construction or take the link out for now?

Also I didn't see an open issue for this or a note in the wiki. This seems like a big task, I'm wondering if I missed it in the milestones.

tomschenkjr commented 6 years ago

@RaedMan - I've included the language under the "City Policies and Requirements Regarding Use of API Services".

Let me know your thoughts.

geneorama commented 6 years ago

@tomschenkjr thanks for the clarifications about what's going into .5 vs .6. This is good for .5.

tomschenkjr commented 6 years ago

v0.5.0 has been deployed to the production servers! I am merging this code.

I will be sending an email to health partners so they can conduct some testing.

@RaedMan - the new web-based documentation will be updated as well. You can show the Lead Safe documentation to team members, which they can view in browsers: https://chicago.github.io/lead-safe-api-docs/

geneorama commented 6 years ago

So far all the tests are passing (including expected errors), except for QA because there's a problem with the actual server. George has opened a ticket with EKI on that.