Chicago / opengrid

A user-friendly, map-based tool to combine and explore real-time or historical data.
http://opengrid.io
Other
246 stars 53 forks source link

Support direct URL/links to app resources/actions such as Advanced Search, Layers, Manage etc. #115

Closed rladines closed 7 years ago

rladines commented 9 years ago

Only focus on Shareable Queries for now -- not adv search, layers, manage, etc.

Link to a query and executing that link.

tomschenkjr commented 9 years ago

Like https://url.net/manage?

rladines commented 9 years ago

Right, or https://url.net/query?name=CouponTweets&autosubmit=true

It has to be designed so that the existing command buttons that currently invoke those panels/actions need to issue the same URL so it is consistent.

tomschenkjr commented 8 years ago

I agree. Can you mark #134 as duplicated and close it?

tomschenkjr commented 7 years ago

Have been using this on WindyGrid, but noticing some issue. Namely, issues are arising when sending the link because some programs are truncating the URL after the # symbol that are being used to define the colors.

For instance, this link%20+%202%22%7D%7D%7D,%7B%22dataSetId%22:%22west_nile_virus%22,%22filters%22:%7B%22condition%22:%22AND%22,%22rules%22:%5B%7B%22id%22:%22when.collection_date%22,%22field%22:%22when.collection_date%22,%22type%22:%22date%22,%22input%22:%22text%22,%22operator%22:%22greater%22,%22value%22:%222%20weeks%20ago%22%7D%5D%7D,%22rendition%22:%7B%22color%22:%22#32CD32%22,%22opacity%22:%2285%22,%22size%22:%7B%22columnId%22:%22what.total_mosquitoes%22,%22calculator%22:%22(Math.sqrt(@v)%20*%202.5)%20+%202%22%7D%7D%7D%5D,%22sharedWith%22:%7B%22users%22:%5B%5D,%22groups%22:%5B%5D%7D,%22isCommon%22:false,%22autoRefresh%22:false,%22refreshInterval%22:%2230%22,%22_id%22:%7B%22$oid%22:%2259483d20e5eb0f137089c093%22%7D,%22geoFilter%22:%7B%22boundaryType%22:%22within%22,%22boundary%22:%22map-extent%22%7D%7D&loc=41.80919639152055,-87.86659240722658,11&run=true&=1232428846608) is being truncated when embedding the link in a Microsoft Outlook email (e.g., inserting a link).

The hash/pound symbols aren't being encoded. However, when switching # to %23, the links are able to be shared and are also being properly interpreted by WG.

Would it be possible to encode the # in the URL being generated by the application?

/cc @geneorama

reve0716 commented 7 years ago

It works with newer version outlook and not with outlook desktop version 2010.

tomschenkjr commented 7 years ago

This should be expected. Outlook 2010 has a limit of 1033 charactershttps://social.technet.microsoft.com/Forums/lync/en-US/bfbaf146-5f48-42cc-8172-41eb7be2e595/outlook-2010-what-is-the-character-limit-for-a-link-to-open?forum=outlook in a link.

Please proceed with releasing the patch for this.

From: Regina [mailto:notifications@github.com] Sent: Wednesday, June 28, 2017 3:04 PM To: Chicago/opengrid opengrid@noreply.github.com Cc: Schenk, Tom Tom.Schenk@cityofchicago.org; Comment comment@noreply.github.com Subject: Re: [Chicago/opengrid] Support direct URL/links to app resources/actions such as Advanced Search, Layers, Manage etc. (#115)

It works with newer version outlook and not with outlook desktop version 2010.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/opengrid/issues/115#issuecomment-311771993, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0cf0Q09cRBA3O6yxnyGBqWUkExvoks5sIrGYgaJpZM4F9rE_.


This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

tomschenkjr commented 7 years ago

@nfspeedypur and @rladines - I see this issue is appearing in OpenGrid.io.

@rladines - did the patch you release in WindyGrid make it into the OpenGrid code or does that need to be ported?

rladines commented 7 years ago

It should be there. These are the commits that were part of that fix: Main.js AdvancedSearch.js

@nfspeedypur Can you confirm that these were merged into the OpenGrid.io code?

tomschenkjr commented 7 years ago

Ok, looks like I didn't do the test right on my end. Closing for now. Thanks everyone!

tomschenkjr commented 7 years ago

Re-opening this as I am seeing the bug pop-up. Here is a query that I generated from OpenGrid. There is a # appearing in the URL path.

https://chicago.opengrid.io/opengrid/#/query?q=%7B%22name%22:%22%22,%22owner%22:%22NoAuth%22,%22spec%22:%5B%7B%22dataSetId%22:%22food_inspections%22,%22filters%22:%7B%7D,%22rendition%22:%7B%22color%22:%22%252387CEEB%22,%22opacity%22:%2280%22,%22size%22:%226%22%7D%7D,%7B%22dataSetId%22:%22crimes_2001_to_present%22,%22filters%22:%7B%7D,%22rendition%22:%7B%22color%22:%22#FFD700%22,%22opacity%22:%2280%22,%22size%22:%226%22%7D%7D,%7B%22dataSetId%22:%22311_service_requests_graffiti_removal%22,%22filters%22:%7B%7D,%22rendition%22:%7B%22color%22:%22#6495ED%22,%22opacity%22:%2280%22,%22size%22:%226%22%7D%7D%5D,%22sharedWith%22:%7B%22users%22:%5B%5D,%22groups%22:%5B%5D%7D,%22isCommon%22:false,%22autoRefresh%22:false,%22refreshInterval%22:%2230%22,%22geoFilter%22:%7B%22boundaryType%22:%22near%22,%22boundary%22:%22_marker%22,%22value%22:%7B%22type%22:%22FeatureCollection%22,%22features%22:%5B%7B%22type%22:%22Feature%22,%22properties%22:%7B%7D,%22geometry%22:%7B%22type%22:%22Point%22,%22coordinates%22:%5B-87.62751102447511,41.877405938278116%5D%7D%7D%5D%7D,%22maxRadius%22:%22500%22,%22maxRadiusUnit%22:%22feet%22%7D%7D&run=true&_=361007470259

tomschenkjr commented 7 years ago

I haven't been able to replicate the bug in WindyGrid, even by using the same query.

rladines commented 7 years ago

@tomschenkjr was able to recreate this, even on the windygrid side. we had a bug where a single replace is done instead of global. should be fixed with branch iss115. I will submit a PR for the fix.

tomschenkjr commented 7 years ago

Closed by 8fe5094