Chicago / opengrid

A user-friendly, map-based tool to combine and explore real-time or historical data.
http://opengrid.io
Other
246 stars 53 forks source link

Open Weather Layers not working #301

Closed tomschenkjr closed 7 years ago

tomschenkjr commented 7 years ago

When clicking on an open weather layer, e.g., temperature, nothing appears to happen.

When I open the Javascript console in Chrome, I see there are several errors that Failed to load resource: the server responded with a status of 401. Below is a screenshot.

Through experimentation, it's clear this is related to anytime an open weather map layer is chosen.

image

nfspeedypur commented 7 years ago

I just took a look into this and I am seeing a 404 error when we try to hit the map images.

image

This all still works on WindyGrid correct?

nfspeedypur commented 7 years ago

Could these APIs have changed? From what I see on OpenWeatherMap.org the url requires an API key which we do not have in the project.

API Details - https://openweathermap.org/api/weathermaps

tomschenkjr commented 7 years ago

It's an issue in WindyGrid, too.

You beat me to it (was just looking at the code) -- I think that's what changed, the required API key. We'll get one of those and add it.

tomschenkjr commented 7 years ago

@nfspeedypur - I've registered an API key and will email it to you.

Right now, it's limited to 60 calls per hour. We'll see if we hit that limit very much.

tomschenkjr commented 6 years ago

Still appears to have an issue with "Cloud Cover"

nfspeedypur commented 6 years ago

When I go onto OpenWeatherMap.org the cloud map looks hard to really see a difference. Could there be an issue with the transparency?

-David

On Mon, Oct 2, 2017 at 10:14 AM, Tom Schenk Jr notifications@github.com wrote:

Still appears to have an issue with "Cloud Cover"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chicago/opengrid/issues/301#issuecomment-333565282, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJYewxaOcy9NO13vh56F2ucJ0hbJmEPks5soP3PgaJpZM4NzURP .

tomschenkjr commented 6 years ago

Don't think that's the issue in this case. I had spotted errors, 404, in the console when trying to load cloud cover. The rest of the layers work, though.

nfspeedypur commented 6 years ago

Tom/Rod,

Can you guys check to see if this API is similar to what you guys are using on WindyGrid? Removed the beginning of the APPID

http://a.tile.openweathermap.org/clouds/14/4202/6088.png?APPID=XXXXXXXXXXXXXXXXXafe

-David

rladines commented 6 years ago

This is what we have on WindyGrid. Looks like we're missing the /map/ portion of the URL. Sorry, I missed this when I updated the APPIDs on the OpenGrid side. http://{s}.tile.openweathermap.org/**map**/clouds/{z}/{x}/{y}.png?APPID=XXXXXXXXXXXXXXX

@nfspeedypur feel free to update the URL

nfspeedypur commented 6 years ago

I will add this to the next release.

tomschenkjr commented 6 years ago

Thanks, so this will be added with the 1.4.3 release?

From: David Matthews [mailto:notifications@github.com] Sent: Monday, October 23, 2017 11:50 AM To: Chicago/opengrid opengrid@noreply.github.com Cc: Schenk, Tom Tom.Schenk@cityofchicago.org; Author author@noreply.github.com Subject: Re: [Chicago/opengrid] Open Weather Layers not working (#301)

I will add this to the next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/opengrid/issues/301#issuecomment-338723286, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0ZLCQ8iZsIPfbZQCNJO5RsV1M2EIks5svMPHgaJpZM4NzURP.


This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

reve0716 commented 6 years ago

@nfspeedypur the updates for opengrid for this issue has been push over to production; when I tested the weather layers I m still seeing the same behavior for the cloud coverage.

nfspeedypur commented 6 years ago

Regina,

The code was merged to production OpenGrid this past weekend. I will be making a new release from the Smart Chicago repo in the next day.

Thanks, David Matthews

On Tue, Nov 14, 2017 at 12:32 PM, Regina notifications@github.com wrote:

@nfspeedypur https://github.com/nfspeedypur the updates for opengrid for this issue has been push over to production; when I tested the weather layers I m still seeing the same behavior for the cloud coverage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chicago/opengrid/issues/301#issuecomment-344353534, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJYe_uJMa7sTVVMTZ_nyptm8RmAIzwZks5s2dyzgaJpZM4NzURP .

nfspeedypur commented 6 years ago

This code has been released to production.

-David

On Tue, Nov 14, 2017 at 1:27 PM, David Matthews nfspeedypur@gmail.com wrote:

Regina,

The code was merged to production OpenGrid this past weekend. I will be making a new release from the Smart Chicago repo in the next day.

Thanks, David Matthews

On Tue, Nov 14, 2017 at 12:32 PM, Regina notifications@github.com wrote:

@nfspeedypur https://github.com/nfspeedypur the updates for opengrid for this issue has been push over to production; when I tested the weather layers I m still seeing the same behavior for the cloud coverage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chicago/opengrid/issues/301#issuecomment-344353534, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJYe_uJMa7sTVVMTZ_nyptm8RmAIzwZks5s2dyzgaJpZM4NzURP .

reve0716 commented 6 years ago

Thanks @nfspeedypur I've completed testing in OG, cloud coverage is functioning properly.

image