Chicago / opengrid

A user-friendly, map-based tool to combine and explore real-time or historical data.
http://opengrid.io
Other
246 stars 53 forks source link

Table Grid Information not displaying for POI Searches and Address Searches when running a Quick Search #321

Closed reve0716 closed 6 years ago

reve0716 commented 7 years ago

Table does not appear in POI search also error message appears below.

ogqs

tomschenkjr commented 6 years ago

@reve0716 - can you open an SMS ticket on this? Thanks.

reve0716 commented 6 years ago

Hi @nfspeedypur for issue #321 whats the eta on the push to merge into production.

reve0716 commented 6 years ago

@nfspeedypur There was issue awhile back where the Quick Search address and place searches were returning an error message of: No creation Time Stamp, I know it was fixed in WindyGrid was the same fixed implemented in OpenGrid?

image

nfspeedypur commented 6 years ago

The Windygrid change was merged in and release. However it does not look like it is working. I can work on troubleshooting this issue and see about getting a new patch out there.

-David

On Fri, Feb 2, 2018 at 9:42 AM, Regina notifications@github.com wrote:

@nfspeedypur https://github.com/nfspeedypur There was issue awhile back where the Quick Search address and place searches were returning an error message of: No creation Time Stamp, I know it was fixed in WindyGrid was the same fixed implemented in OpenGrid?

[image: image] https://user-images.githubusercontent.com/12734080/35741243-eb1e317c-07fc-11e8-9385-8b6a3a32794b.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chicago/opengrid/issues/321#issuecomment-362621179, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJYe616Chjm5hRPX_ENdBT8VEDvbWaPks5tQyzOgaJpZM4PI9FV .

reve0716 commented 6 years ago

@nfspeedypur Ok, thanks

nfspeedypur commented 6 years ago

image

I have fixed this issue. I am not sure how, but it seems like 1 of the last check ins never made it to the OpenGrid release. This has been updated.

tomschenkjr commented 6 years ago

Thanks. For clarification, were the changes on the master branch of Chicago/opengrid or did you have to make a local change?

That is, do we need to update the main branch of opengrid?

From: David Matthews [mailto:notifications@github.com] Sent: Monday, February 12, 2018 9:43 AM To: Chicago/opengrid opengrid@noreply.github.com Cc: Schenk, Tom Tom.Schenk@cityofchicago.org; State change state_change@noreply.github.com Subject: Re: [Chicago/opengrid] Table Grid Information not displaying for POI Searches and Address Searches when running a Quick Search (#321)

[image]https://user-images.githubusercontent.com/12736635/36104905-dde85990-0fd8-11e8-81db-15269c1835e0.png

I have fixed this issue. I am not sure how, but it seems like 1 of the last check ins never made it to the OpenGrid release. This has been updated.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/Chicago/opengrid/issues/321#issuecomment-364961972, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0UIo44J39Exck24YKnDw3Bp81ZJsks5tUFwdgaJpZM4PI9FV.


This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

nfspeedypur commented 6 years ago

No update is needed. The code change Rod made last fall fixed the issue and the code merge into SmarChicago Repo worked. However the odd part is that when I pulled down the repo to release the code in November I only got 1 of the 2 changes. I am not sure if there was a file conflict that caused it, but I was able to pull down the change on Monday and pushed out the code.

-David

On Feb 13, 2018 9:49 AM, "Tom Schenk Jr" notifications@github.com wrote:

Thanks. For clarification, were the changes on the master branch of Chicago/opengrid or did you have to make a local change?

That is, do we need to update the main branch of opengrid?

From: David Matthews [mailto:notifications@github.com] Sent: Monday, February 12, 2018 9:43 AM To: Chicago/opengrid opengrid@noreply.github.com Cc: Schenk, Tom Tom.Schenk@cityofchicago.org; State change < state_change@noreply.github.com> Subject: Re: [Chicago/opengrid] Table Grid Information not displaying for POI Searches and Address Searches when running a Quick Search (#321)

[image]https://user-images.githubusercontent.com/ 12736635/36104905-dde85990-0fd8-11e8-81db-15269c1835e0.png

I have fixed this issue. I am not sure how, but it seems like 1 of the last check ins never made it to the OpenGrid release. This has been updated.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/ Chicago/opengrid/issues/321#issuecomment-364961972, or mute the thread< https://github.com/notifications/unsubscribe-auth/ ABkC0UIo44J39Exck24YKnDw3Bp81ZJsks5tUFwdgaJpZM4PI9FV>.


This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Chicago/opengrid/issues/321#issuecomment-365308000, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJYe-KDkEqtrRRNGP5QnmZrLAYrZwD0ks5tUa8YgaJpZM4PI9FV .

tomschenkjr commented 6 years ago

Thanks.

@reve0716 - please check this as well and close the issue if you agree that it's been fixed.

reve0716 commented 6 years ago

Testing has been completed.