search

ChicagoFlyhouse / AutomationConsole

0 stars 1 forks source link

Better Distinction between locked groups and Fault groups #1

Open HunterACole opened 6 months ago

HunterACole commented 6 months ago

When viewed from the axis pool, there's no way to tell if a group is a fault group or a locked group. A visual distinction between the type of groups is necessary Grouping Distinction e.x. : In above photo, no way to determine which of the 4 groups is locked vs fault

HunterACole commented 6 months ago

This issue was reported by Mark from our time at Perelman. From my understanding, all of the above groups are fault groups, as the locked groups use the stacked display

code-warriors-llc commented 6 months ago

@HunterACole We have decided on the below approach to distinguish between the fault and locked group The red border represents the - Fault group and with no border is called a Locked group Let us know if it is fine and user-friendly.

image (13)

HunterACole commented 6 months ago

Do you we think we could make the red line a few pixels thicker? Distinction is good, but can be hard to see in less ideal lighting situations

code-warriors-llc commented 6 months ago

Sure will update the design.

HunterACole commented 6 months ago

After checking with @jsavageflyhouse, we'd like a different color of red and an extra icon for locked groups. Picture with changes included. Can we make the outline color the same blue as the UI, and add some lock symbol in between axis in a locked group? Updated Group Distinction

code-warriors-llc commented 6 months ago

Hi @HunterACole - We implemented like this as you mentioned in image please have a look and confirm the changes.

image

HunterACole commented 6 months ago

The changes look good to me. Given Mark's comments in Slack this morning, I'm going to confirm if Mark is happy with this look before we close the issue but I'm feeling positive about it

code-warriors-llc commented 6 months ago

Sure @HunterACole

code-warriors-llc commented 6 months ago

@HunterACole -Should the lock icon always be positioned at the bottom center in the locked group view?

HunterACole commented 6 months ago

Either the bottom center or always between the first to axis in the group

code-warriors-llc commented 6 months ago

@HunterACole - We currently display the lock icon at the bottom center of the locked group view, as shown in the attached image. Please take a look. image

HunterACole commented 6 months ago

Option 2 is the preferred method

code-warriors-llc commented 6 months ago

@HunterACole - Like this ? image

HunterACole commented 6 months ago

Yes exactly! Could we also make the icon larger

code-warriors-llc commented 6 months ago

Sure @HunterACole .

code-warriors-llc commented 6 months ago

@HunterACole - Is it enough ? image

HunterACole commented 5 months ago

That looks good

HunterACole commented 5 months ago

Confirmed on both handheld and large console today lock symbol looks great. We think that with the clarity of lock symbol, we can remove colored ring around fault groups

code-warriors-llc commented 5 months ago

@HunterACole - Yes we can remove coloured ring around fault groups but then how we will represent the fault group for improve user experience.

HunterACole commented 5 months ago

With only two possible grouping styles, locked and fault, we are confident users will understand that any group without the lock icon is considered a fault group

code-warriors-llc commented 5 months ago

Ok we will remove ring from fault group Thanks for the response

code-warriors-llc commented 5 months ago

Ring removed changes are on the testconsole. Available for your testing , send feedback on application general flow.

HunterACole commented 5 months ago

Looks good in application flow so far. The handheld's display seems inconsistent. Looked right for me in my testing, but when @jsavageflyhouse used it, two axis grouped together each had individual group circles instead of being grouped together