ChicagoJS / chicagojs.org

Home page of ChicagoJS.org. Pull Requests welcome!
https://chicagojs.org
MIT License
9 stars 13 forks source link

Bug: positionType Not Defined #26

Closed Alek-S closed 5 years ago

Alek-S commented 5 years ago

When running master branch, getting a positionType error from the gql query in src/pages/job-listings/index.js since it’s a not a defined type (also breaks routing when running locally). This looks like originated with PR #20.

There are two options for resolving it:

I can open open up a PR with either option as a fix, wanted to see with the group if there was a preference.

peterpme commented 5 years ago

Ah snap, thanks for catching this! Here's what the job listing fields are going to look like:

[
    {
        "logoUrl": "https://draftbit.com/logo.svg",
        "applyUrl": "https://draftbit.com/apply",
        "address": "343 W Erie #310 Chicago, IL 60654",
        "featured": true,
        "position":  "Platform Engineer",
        "company": "Drafbit",
        "datePosted": "2018-12-03T15:18:31.433Z",
        "neighborhood": "River North",
        "technologies": ["Javascript", "Node.js", "React.js", "React Native"],
        "benefits": ["Health Insurance", "401k", "Unlimited Vacation Policy", "Dental Insurance"],
        "description": "Draftbit is hiring"
    }
]
Alek-S commented 5 years ago

hmm, looks like positionType not actually used, so probably better to go with option 1 and take it out then. I can open a PR, it's a one-line fix.