Open OniBait opened 10 years ago
CoryManson
commented
10 years ago Would really appreciate if this could be looked at. One of my servers is crashing upwards of 20 times per day with this exact crash.
Here's another crash which is extremely similar: http://pastebin.com/eMjqC6zD
Chicken-Bones
commented
10 years ago To save me writing it all again, I'll link my response to a similar request. https://bitbucket.org/ChickenBones/translocator/issue/16/nullpointerexception-in
tldr; Simply putting a guard may have worse side effects. The fact that the crash is so extremely rare means it's likely not a simple Forge + CCL interaction. I need instructions on how to replicate the crash in order to properly fix it.
CoryManson
commented
10 years ago I'm more than happy to supply a download of my server and a couple of hundred crash logs that have occurred over the past week.
Chicken-Bones
commented
10 years ago Only issue is, I can't really debug a non-forge server.
CoryManson
commented
10 years ago This crash occurs under Forge and MCPC+ as per Onibaits post and linked crashlog
Chicken-Bones
commented
10 years ago Well then, a setup I can debug would be nice
frycjiri
commented
10 years ago Before Chicken-Bones repair it, you can use my solution, https://github.com/Chicken-Bones/CodeChickenLib/pull/25 Download here: http://ci.technicraft.cz/job/CodeChickenLib/4/
/Edit: Sorry this wont solve this issue. (probably) :(
Chicken-Bones
commented
9 years ago Hopefully fixed in feb8bfd02895ee4cd5bbf8d8a264450249b16234 (1.7.10-1.1.1.106)
Crash from Vanilla Forge http://pastebin.com/EtqqLizV
This isn't an MCPC+ specific issue and could easily be fixed by putting some null checks in your code (if you want me to submit a PR, I'd be glad to).
Also, looking at it, it seems like there is at least the potential for some memory leakage since you are using Chunks as keys (instead of ChunkCoordIntPair) and not using something like a WeakHashMap...