search

ChickenKyiv / foodolog

Food Log is a project, where user can log meals
GNU General Public License v3.0
0 stars 1 forks source link

added app-logic, storage #7

Closed iankiku closed 6 years ago

atherdon commented 6 years ago

you need my review or i need to merge it?

iankiku commented 6 years ago

If you would like to review it will be great. Also, I'm about to connect to the MongoDB

atherdon commented 6 years ago

Good, will check it soon. thanks for letting know about mongodb connection

atherdon commented 6 years ago

I didn't find anything that looks not perfect. I like your code style at this point.

Questions: Did you test model validation and how configured ACL works? Did upload work well too? I mean i'm dropping a file and it moved to files folder, etc?

atherdon commented 6 years ago

It's good to see that you also add a testing environment. Btw, if you just started to learn mocha & chai - please pause that learning. As parts of this project using React, I find out that FB advising to use Jest as testing tool. It's a bit similar, but i wanted to use a one tool at different repos, for backend and frontend.

I'm approving this pull