ChickenKyiv / loopback-tutor-intern-8

https://loopback-react-account.herokuapp.com/
https://groceristar.netlify.com/
GNU General Public License v3.0
0 stars 1 forks source link

i think this is a bad line #22

Closed atherdon closed 6 years ago

atherdon commented 6 years ago

https://github.com/ChickenKyiv/loopback-tutor-intern-8/blob/5b185d25e92bf72fb702023fb7be351df4422f02/providers.json#L8

because we'll need to change it. check this for a references: https://github.com/GroceriStar/groceristar/blob/master/providers.json

atherdon commented 6 years ago

other things that i find: https://github.com/strongloop/loopback-example-passport/blob/master/providers.json.template https://www.npmjs.com/package/passport-google-token-loopback but not sure if it works, for sure

chauhannishith commented 6 years ago

Corrected this. Shouldn't break anything,

atherdon commented 6 years ago

did you know how attach commits to issues?

chauhannishith commented 6 years ago

closes #no ?

atherdon commented 6 years ago

yeah, use it in commit message.