ChickenKyiv / loopback-tutor-intern-8

https://loopback-react-account.herokuapp.com/
https://groceristar.netlify.com/
GNU General Public License v3.0
0 stars 1 forks source link

organizing calls #62

Open atherdon opened 6 years ago

atherdon commented 6 years ago

based on this commit: https://github.com/ChickenKyiv/loopback-tutor-intern-8/commit/17164e7e81cd34f0381082a823ea5c3fce2943e9

I think we need to split our conversation into two big topics: 1) moving api urls into a separated functions/methods, so it'll make our live easy when some routes will be changed 2) updating code at api-sample file and maybe moving it as separated package. because we'll use a same logic at other projects too, so i think it's a better way than just copy-paste.

chauhannishith commented 6 years ago

moving api urls into a separated functions/methods, so it'll make our live easy when some routes will be changed

all axios calls with url are placed into the helpers folder so thats the only place where you will find urls except the google/twitter login because i couldn't find a way to modify it using variables

updating code at api-sample file and maybe moving it as separated package. because we'll use a same logic at other projects too, so i think it's a better way than just copy-paste.

they might be useful but not as it is as each file goes to a unique url right now but we will be having components which could use the same function but we haven't had any created yet