search

ChickenKyiv / recipe-app-react-native

https://chickenkyiv.github.io/application-documentation/
23 stars 17 forks source link

add link to expo #162

Closed atherdon closed 5 years ago

atherdon commented 5 years ago

Description/Steps to reproduce

I spotted a few components that need to be created in the Todo column of the Trello board. However, I can't load the app in snack.expo.io through its github repository. It states the following: image So how can I load the app to see it live? @lunvjp can you assist?

Expected result

Additional information

jackphuongvu commented 5 years ago

That's weird. it works with my test link: https://github.com/lunvjp/test-snack-import.git I need to debug it for a while

SofianeDjellouli commented 5 years ago

@lunvjp It doesn't work with your link either image

jackphuongvu commented 5 years ago

Oh..Let me check it.

jackphuongvu commented 5 years ago

it works well with me. https://snack.expo.io/@git/github.com/lunvjp/test-snack-import That's weird.

atherdon commented 5 years ago

Guys, what do you think if we'll make a new setup? i think this can help us. tell me what you think

On Sun, Oct 7, 2018 at 9:42 AM lunvjp notifications@github.com wrote:

it works well with me. https://snack.expo.io/@git/github.com/lunvjp/test-snack-import That's weird.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-app-react-native/issues/162#issuecomment-427630062, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDozuprykbFR7YKDoO3Nl_XcBziicks5uiaJTgaJpZM4XLUX9 .

jackphuongvu commented 5 years ago

It's no problem from me. Let me updated about it. What kinds of new setup should we make for now?

atherdon commented 5 years ago

@SofianeDjellouli what do you think is the easiest way to solve this issue?

atherdon commented 5 years ago

i think we should also connect @Naaman-Saif to this conversation

SofianeDjellouli commented 5 years ago

The test project now works with me. I just had to save it on my account.

For the Recipe App, there's an issue with the compatibility of Expo and React Native in package.json. To check for compatible versions: https://docs.expo.io/versions/latest/sdk/#sdk-version. You should downgrade React Native to version 0.55.4.

atherdon commented 5 years ago

got it. it's my fault - I usually like to keep dependencies updated to the latest versions. can you fix it?

On Sun, Oct 7, 2018 at 12:25 PM Sofiane Djellouli notifications@github.com wrote:

The test project now works with me. I just had to save it on my account.

For the Recipe App, there's an issue with the compatibility of Expo and React Native in package.json. To check for compatible versions: https://docs.expo.io/versions/latest/sdk/#sdk-version. You should downgrade React Native to version 0.55.4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-app-react-native/issues/162#issuecomment-427638609, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDi8iptW6rgeINTReQEphAgDyiNhzks5uiciLgaJpZM4XLUX9 .

SofianeDjellouli commented 5 years ago

Here you go for the snack version: https://snack.expo.io/@sofianed/recipe-app I still can't run it locally though. Keeps telling me it can't find index.js. Seems to be an issue related to babel and its dependencies.

Naaman-Saif commented 5 years ago

Hi Sofiane. Thank you so much. I saw this earlier but thought it was only me. I'll get this done soon.

atherdon commented 5 years ago

@SofianeDjellouli please update a Readme, so anyone will know about this link.

Btw, if you think we should reoder or reorganize structure - discuss this with @Naaman-Saif and decide what to do. i'm sure @lunvjp will be ok with this plan

SofianeDjellouli commented 5 years ago

PR Update README.md with Snack Expo link #164

atherdon commented 5 years ago

PR merged

On Wed, Oct 10, 2018 at 11:30 AM Sofiane Djellouli notifications@github.com wrote:

PR Update README.md with Snack Expo link #164 https://github.com/ChickenKyiv/recipe-app-react-native/pull/164

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-app-react-native/issues/162#issuecomment-428484682, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDosueNoabypKPbZ4ww0R7wYMrkE1ks5ujbARgaJpZM4XLUX9 .

SofianeDjellouli commented 5 years ago

@atherdon thanks @Naaman-Saif PR with proper versions: https://github.com/ChickenKyiv/recipe-app-react-native/pull/165

atherdon commented 5 years ago

merged too. i think i'll be more careful with updating packages for this project - don't want to break it again.

On Wed, Oct 10, 2018 at 12:43 PM Sofiane Djellouli notifications@github.com wrote:

@atherdon https://github.com/atherdon thanks @Naaman-Saif https://github.com/Naaman-Saif PR with proper versions: #165 https://github.com/ChickenKyiv/recipe-app-react-native/pull/165

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-app-react-native/issues/162#issuecomment-428507975, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDtgBBcw8BXB_8tDK4BzzE2Q_qJ92ks5ujcFFgaJpZM4XLUX9 .

atherdon commented 5 years ago

ok, i think this issue can be closed