search

ChickenKyiv / recipe-search-react

We're replicating advanced search for recipe based projects
https://modest-shannon-513067.netlify.com/
1 stars 3 forks source link

submit handler #45

Closed atherdon closed 6 years ago

atherdon commented 6 years ago

will you be able to create a form submission to this api? as told you before - don't have exact name for method that will apply for all filters, so just include backend urls with .env file as we did on your repository.

chauhannishith commented 6 years ago

yeah i think we just hit a daily number of requests. maybe for debuggin reasons we should fetch some static data like ingredients and save them as json - while we're testing it?

static will most probably work fine might be possible better than this but this looks more like real life scenario where user will fetch data over the web

chauhannishith commented 6 years ago

maybe they just haven't recipe with that cases? so it's like a 'No results' response?

i assume this might be possible but i even tried a static request and that too failed, they probably might have given an error response to handle failure

atherdon commented 6 years ago

ok i think it's can be a two same issues in one time - first of all they might didn't have ingredients that we're picking, second is related to limitation of a free account and maybe we just need to try an ingredients that can be in one recipe.

usually, i test food projects with chicken or salad options. because it's a simple cases. for more complex cases - when you want to check intersections, like receive recipes with chicken(like soup) and chicken salad - we'll need to go to the main website - search few recipes and use them as test cases

have given an error response to handle failure it'll be sad if they don't cover errors. we like have it covered(loopback did it for basic methods) in our recipe-search-api

chauhannishith commented 6 years ago

i had spent atleast two hours yesterday trying different combinations and it worked with balanced diet but not others so i assume it might be because of free acount

atherdon commented 6 years ago

yeah i think so. but it's good that we're tried to connect our form to separated API. it's good for testing on separated service. i think soon we'll switch to our server, so it'll be more easy to understand - if'll get errors. because you'll be able to grab long URL - put it on your browser and see an actual json response

On 07-Jun-2018 at 12:32 PM, chauhannishith wrote:

i had spent atleast two hours yesterday trying different combinations and it worked with balanced diet but not others so i assume it might be because of free acount

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChickenKyiv/recipe-search-react/issues/45#issuecomment-395403490, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrDi-0aqxevWIFduwKek2o7R8VUTFKks5t6R1IgaJpZM4UM-aC .